Jump to content


Google Ads are only seen by non-members of RMweb - Create an RMweb account and you'll only receive modelling ads.

Photo

Problems with joining Groups




  • Please log in to reply
16 replies to this topic

#1 trisonic

trisonic

    Member


  • Members
  • PipPip
  • 8,731 posts
  • LocationNoo Yawk, USA

Posted 23 May 2011 - 20:24

I have now heard of two people who I sent invites to who have been unable to join because clicking on "JOIN" in the invite does nothing.......
I look up my invite list and they are listed as "Pending".

The two are: Mike Boucher and Gil Janus (see his post in "Forum Help" under: "Unread Notification bug" sic) whilst Gil's looks more complex I think it is the same problem. I've pm'ed Andy.
As I have a lot of people listed under Pending some of them may have simply not complained yet

Best, Pete.

Google Ads are only seen by non-members of RMweb - Create an RMweb account and you'll only receive modelling ads.

#2 trisonic

trisonic

    Member


  • Members
  • PipPip
  • 8,731 posts
  • LocationNoo Yawk, USA

Posted 23 May 2011 - 20:41

The strange thing about Mike Boucher is that he is listed as Pending in my Invite list but he has also posted already in the USA & Canada Railroad Group! It's a D'oh moment.....

Best, Pete.

#3 Kris

Kris

    Member


  • Members
  • PipPip
  • 6,248 posts
  • LocationSomewhere in darkest Cornwall

Posted 23 May 2011 - 20:50

Has this only happened with people that you have invited Pete?

As to the posting - Anyone can post in the groups whether they are a member or not, unless you have changed non member privileges. (It did start off that you had to be a member before you could post but Andy changed the privileges for all groups).

#4 trisonic

trisonic

    Member


  • Members
  • PipPip
  • 8,731 posts
  • LocationNoo Yawk, USA

Posted 24 May 2011 - 05:02

It did occur to me that maybe I had sent out too many invites...........well, it was either do that or mow the lawn............

Best, Pete.

#5 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 07:43

If they show as pending it does mean the invite sent at least. Mike's issue may be similar to that also mentioned by Gil Janus (it occasionally happens and only seems to clear after the next message comes in).

Most of the issue still surrounds the issue with the Join button for IE users.

#6 martin_wynne

martin_wynne

    Member


  • Members
  • PipPip
  • 6,494 posts
  • LocationWest of the Severn, UK

Posted 24 May 2011 - 08:09

Most of the issue still surrounds the issue with the Join button for IE users.

Hi Andy,

Here's a short-term kludge fix if you want to use it:

Find this bit in the template in blue and insert after it the bit in red:

<a title="Join Group"><img alt="Join Group" src="http://www.rmweb.co....white_add.png"> Join Group</a><a title="click this to join if you are using Internet Explorer" onclick="getElementById('hiddenContent').style.display='block';">&nbsp; Join Group Using IE</a>
This is what it looks like:

ie_group_kludge.png

It works -- I just used it to join Pete's USA group. :)

regards,

Martin.

#7 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 08:32

I'm feeling like a bit of a muppet now Martin, 15 minutes of searching the templates and the files and I still can't locate it.

#8 martin_wynne

martin_wynne

    Member


  • Members
  • PipPip
  • 6,494 posts
  • LocationWest of the Severn, UK

Posted 24 May 2011 - 08:59

I'm feeling like a bit of a muppet now Martin, 15 minutes of searching the templates and the files and I still can't locate it.

Sorry I can't help as I don't have the software. It probably doesn't look exactly like that in the template. You should be able to find it by searching all files for the string "Join Group".

If you don't have it, the program Notepad++ (free) is a brilliant text and script editor and can search all files in a folder: http://notepad-plus-plus.org/

regards,

Martin.

#9 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 09:20

Thanks Martin,

Sure enough Notepad++ found it in a file \admin\applications_addon\other\groups\modules_public\view\view.php

I tried dropping it straight into the line:

$join['button'] = '<li><a title="Join Group" href="'.$this->settings['base_url'].'app=groups&module=view&gid='.$this->group['g_id'].'&do=join&inv_key=' . $this->request['inv_key'] .'&s=' . $this->memberData['publicSessionID'] . '" rel="nofollow"><img alt="Join Group" src="'.$this->settings['img_url'].'/page_white_add.png"> Join Group</a><a title="Click this to join if you are using Internet Explorer" onclick="getElementById('hiddenContent').style.display='block';">&nbsp; Join Group Using IE</a></li>';

This generated an error when accessing the front page of the Group containing that:

Parse error: syntax error, unexpected T_STRING in /home/rmwebco/public_html/community/admin/applications_addon/other/groups/modules_public/view/view.php on line 159


which corresponds to the relevant line in the file.

I guess it needs to be formatted into the php script in a similar manner to the 'Join Group' button.Posted Image

#10 martin_wynne

martin_wynne

    Member


  • Members
  • PipPip
  • 6,494 posts
  • LocationWest of the Severn, UK

Posted 24 May 2011 - 10:09

I guess it needs to be formatted into the php script in a similar manner to the 'Join Group' button.Posted Image

Hi Andy,

I think you found the wrong place -- that is the hidden block which comes up when you click the button. Try searching for a later instance of "Join Group", or try searching for instances of "showHiddenContent" .

IPB is an absolute pig to find stuff in and make changes to because the templates and page .php files are merged together. I've ditched my copy of IPB, it was just too much brain pain. The UltraBB code from Jim Hale which I use for Templot Club and Bob Heath uses on YMR is an absolute pleasure to work with in comparison. :)

regards,

Martin.

#11 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 10:20

I'd tried it in that line too to give:

$join['popupButton'] = '<li id="showHiddenContent"><a title="Join Group"><img alt="Join Group" src="'.$this->settings['img_url'].'/page_white_add.png"> Join Group</a><a title="click this to join if you are using Internet Explorer" onclick="getElementById('hiddenContent').style.display='block';">&nbsp; Join Group Using IE</a></li>';

I still get the same syntax error unfortunately.

#12 martin_wynne

martin_wynne

    Member


  • Members
  • PipPip
  • 6,494 posts
  • LocationWest of the Severn, UK

Posted 24 May 2011 - 10:27

I still get the same syntax error unfortunately.

Hi Andy,

Ah. You need to escape all the single quotes with a backslash -- try this:

<a title="click this to join if you are using Internet Explorer" onclick="getElementById(\'hiddenContent\').style.display=\'block\';">&nbsp; Join Group Using IE</a>

Martin.

#13 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 10:30

Fantastic, it displays now!

Thanks ever so much for that. Posted Image

#14 martin_wynne

martin_wynne

    Member


  • Members
  • PipPip
  • 6,494 posts
  • LocationWest of the Severn, UK

Posted 24 May 2011 - 10:47

Fantastic, it displays now!

Thanks ever so much for that. Posted Image

You're welcome Andy. :)

But IE is still being a pig. In IE7 at least, after clicking the new kludge button the hidden panel appears full-width at the bottom of the page. You need to tell IE users to click the new kludge button, then scroll down to the bottom of the page and click the new "Join group" button which will have appeared down there. IE8 and 9 may be better behaved, but why anyone uses IE beats me.

Hopefully the app developer will have this fixed soon.

regards,

Martin.

#15 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 10:53

It seems to behave as it should in IE9.

Whilst weaning folk off IE it would be nice if I could get everyone to use a minimum display width of 1280. :)

#16 Ian J.

Ian J.

    Member


  • Members
  • PipPip
  • 2,258 posts
  • LocationThe Empire of the Suitcase (currently near, but not quite in, Ringwood, Hants)

Posted 24 May 2011 - 11:05

Whilst weaning folk off IE it would be nice if I could get everyone to use a minimum display width of 1280. :)

:blink: I don't think you've got much hope of that. There are still some users out there who use 800x600, many of them for accessibility purposes as it in effect keeps font sizes large.

#17 Andy Y

Andy Y

    RMweb Editor


  • Administrators
  • 14,119 posts
  • LocationStaffs

Posted 24 May 2011 - 11:19

Thankfully the 800 x 600 are few and far between in that respect (or it's near impossible to use the site!). I'm sure a number of the 1024 could be persuaded though even if it's the most numerous and probably problematical).

browsers.jpg


displays.jpg







Google Ads are only seen by non-members of RMweb - Create an RMweb account and you'll only receive modelling ads.